linux-kernel - Re: scripts/get_maintainer.pl misses maintainers sometimes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1499878121.4457.33.camel@perches.com>
Date:   Wed, 12 Jul 2017 09:48:41 -0700
From:   Joe Perches <joe@...ches.com>
To:     Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Daniel Vetter <daniel.vetter@...ll.ch>
Subject: Re: scripts/get_maintainer.pl misses maintainers sometimes

On Wed, 2017-07-12 at 18:36 +0200, Maarten Lankhorst wrote:
> Hello Joe Perches,
> 
> I created a script for drm's maintainer-tools that pipes the output of get_maintainer.pl
> to add the appropriate cc's to the commit message. It also ignores duplicates, so running
> the script twice on the same commit doesn't add everyone twice.
> 
> When testing, I found out that sometimes maintainers were added on the second patch, and
> that made me notice a bug in get_maintainer.pl.
> 
> On the below patch, I get up to 39 maintainers from get_maintainer.pl, but the actual amount 
> differs randomly on each invocation:
> 
> ~/linux$ git show | scripts/get_maintainer.pl | wc -l
> 39
> ~/linux$ git show | scripts/get_maintainer.pl | wc -l
> 37
> ~/linux$ git show | scripts/get_maintainer.pl | wc -l
> 38
> 
> Any idea why this happens?

If you add --nogit --nogit-fallback to the command line
the output is consistent.

So it seems it comes down to that what git log outputs
for the same command varies.

I'll track it down further later.