linux-kernel - Re: [PATCH] igb: fix unused igb_deliver_wake_packet() warning when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170712.143757.39770380256592298.davem@davemloft.net>
Date:   Wed, 12 Jul 2017 14:37:57 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dave.hansen@...ux.intel.com
Cc:     linux-kernel@...r.kernel.org, jeffrey.t.kirsher@...el.com,
        intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org
Subject: Re: [PATCH] igb: fix unused igb_deliver_wake_packet() warning when
 CONFIG_PM=n

From: Dave Hansen <dave.hansen@...ux.intel.com>
Date: Wed, 12 Jul 2017 14:09:25 -0700

> 
> From: Dave Hansen <dave.hansen@...ux.intel.com>
> 
> I'm seeing warnings on kernel configurations where CONFIG_PM is
> disabled.  It happens in 4.12, at least:
> 
> drivers/ethernet/intel/igb/igb_main.c:7988:13: warning: 'igb_deliver_wake_packet' defined but not used [-Wunused-function]
> 
> This is because igb_deliver_wake_packet() is defined outside of
> the #ifdef", but is used only a single time within the #ifdef in
> igb_resume().  Fix it by moving igb_deliver_wake_packet() next to
> igb_resume() inside the #ifdef.
> 
> The diff ends up looking a bit funky here.  It *looks* like
> igb_suspend() is getting moved, but that's an artifact of how
> 'diff' sees the changes.
> 
> Cc: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Cc: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org
> Signed-off-by: Dave Hansen <dave.hansen@...ux.intel.com>

I'll let Jeff queue this up into his tree.