linux-kernel - Re: [PATCH] microblaze/PCI: Remove pcibios_setup_bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <154db2a9-3051-71b7-384c-04e4a29c38c0@xilinx.com>
Date:   Thu, 13 Jul 2017 08:02:59 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Bjorn Helgaas <helgaas@...nel.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>
CC:     <linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Bharat Kumar Gogada <bharatku@...inx.com>,
        Ravi Kiran Gummaluri <rgummal@...inx.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Michal Simek <michal.simek@...inx.com>
Subject: Re: [PATCH] microblaze/PCI: Remove pcibios_setup_bus_{self/devices}
 dead code

On 13.7.2017 04:38, Bjorn Helgaas wrote:
> On Tue, Jun 20, 2017 at 02:08:44PM +0100, Lorenzo Pieralisi wrote:
>> commit 01cf9d524ff0 ("microblaze/PCI: Support generic Xilinx AXI PCIe Host
>> Bridge IP driver") removed pcibios calls to:
>>
>> pcibios_setup_bus_self()
>> pcibios_setup_bus_devices()
>>
>> Given that pcibios_fixup_bus() was the only caller of those functions
>> they have now become dead code (along with the functions they were
>> calling in turn) so they can be removed.
>>
>> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@....com>
>> Cc: Bharat Kumar Gogada <bharatku@...inx.com>
>> Cc: Ravi Kiran Gummaluri <rgummal@...inx.com>
>> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
>> Cc: Michal Simek <michal.simek@...inx.com>
> 
> Applied with Michal's ack to pci/misc for v4.14, thanks!
> 
> I also removed the "Fixup resources of a PCI<->PCI bridge" comment
> since it's no longer applicable.

Thanks,
Michal