linux-kernel - Re: [PATCH v8 1/5] [media] cec.h: Add stub function for cec_register_cec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff7de557-d023-4ca6-d2f0-df13886ab7fc@xs4all.nl>
Date:   Thu, 13 Jul 2017 09:01:51 +0200
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Jose Abreu <Jose.Abreu@...opsys.com>, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Carlos Palminha <CARLOS.PALMINHA@...opsys.com>,
        Hans Verkuil <hans.verkuil@...co.com>
Subject: Re: [PATCH v8 1/5] [media] cec.h: Add stub function for
 cec_register_cec_notifier()

On 10/07/17 17:46, Jose Abreu wrote:
> Add a new stub function for cec_register_cec_notifier() so that
> we can still call this function when CONFIG_CEC_NOTIFIER and
> CONFIG_CEC_CORE are not set.
> 
> Signed-off-by: Jose Abreu <joabreu@...opsys.com>
> Cc: Carlos Palminha <palminha@...opsys.com>
> Cc: Hans Verkuil <hans.verkuil@...co.com>
> ---
>  include/media/cec.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/include/media/cec.h b/include/media/cec.h
> index 56643b2..8357f60 100644
> --- a/include/media/cec.h
> +++ b/include/media/cec.h
> @@ -365,6 +365,14 @@ static inline int cec_phys_addr_validate(u16 phys_addr, u16 *parent, u16 *port)
>  	return 0;
>  }
>  
> +#ifndef CONFIG_CEC_NOTIFIER
> +struct cec_notifier;
> +static inline void cec_register_cec_notifier(struct cec_adapter *adap,
> +					     struct cec_notifier *notifier)
> +{
> +}
> +#endif
> +
>  #endif
>  
>  /**
> 

This isn't quite right. This function prototype needs to be moved to cec-notifier.h.

I also saw that it isn't documented. I'll make a patch for this which will also include
documentation.

Regards,

	Hans