linux-kernel - Re: [alsa-devel] [PATCH] ASoC: fsl_asrc: constify snd_soc_dai_ops structure

Open Source and information security mailing list archives

Date:   Thu, 13 Jul 2017 09:32:41 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Cc:     Timur Tabi <timur@...i.org>, Nicolin Chen <nicoleotsuka@...il.com>,
        Xiubo Li <Xiubo.Lee@...il.com>,
        Fabio Estevam <fabio.estevam@....com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH] ASoC: fsl_asrc: constify snd_soc_dai_ops      structure

Gustavo,

please stop posting in this style.  It's really annoying to see
spontaneously popping-up almost same patch for more than two hours
long.

If you have a series of the same fix patches, send them as a patch
set in a shot with a thread.  git-send-email does it right.

I don't mind a couple of patches posted separately, but this is over
the limit.

thanks,

Takashi

On Thu, 13 Jul 2017 09:23:51 +0200,
Gustavo A. R. Silva wrote:
> 
> This structure is only stored in the ops field of a snd_soc_dai_driver
> structure. That field is declared const, so snd_soc_dai_ops structures
> that have this property can be declared as const also.
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
> ---
>  sound/soc/fsl/fsl_asrc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c
> index 8cfffa7..806d399 100644
> --- a/sound/soc/fsl/fsl_asrc.c
> +++ b/sound/soc/fsl/fsl_asrc.c
> @@ -542,7 +542,7 @@ static int fsl_asrc_dai_trigger(struct snd_pcm_substream *substream, int cmd,
>  	return 0;
>  }
>  
> -static struct snd_soc_dai_ops fsl_asrc_dai_ops = {
> +static const struct snd_soc_dai_ops fsl_asrc_dai_ops = {
>  	.hw_params    = fsl_asrc_dai_hw_params,
>  	.hw_free      = fsl_asrc_dai_hw_free,
>  	.trigger      = fsl_asrc_dai_trigger,
> -- 
> 2.5.0
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@...a-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives