linux-kernel - Re: [PATCH] arm64: dts: ls1012a: add USB host controller nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170713085720.GX3172@dragon>
Date:   Thu, 13 Jul 2017 16:57:21 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Ran Wang <ran.wang_1@....com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Andy Tang <andy.tang@....com>,
        Harninder Rai <harninder.rai@....com>,
        Horia Geantă <horia.geanta@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" 
        <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: ls1012a: add USB host controller nodes

On Thu, Jul 13, 2017 at 08:46:50AM +0000, Ran Wang wrote:
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > > b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > > index b497ac1..8aa2dcf 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > > @@ -411,6 +411,23 @@
> > >  				 <&clockgen 4 3>;
> > >  		};
> > >
> > > +		usb0: usb3@...0000 {
> > > +			compatible = "snps,dwc3";
> > > +			reg = <0x0 0x2f00000 0x0 0x10000>;
> > > +			interrupts = <0 60 0x4>;
> > > +			dr_mode = "host";
> > > +			snps,quirk-frame-length-adjustment = <0x20>;
> > > +			snps,dis_rxdet_inp3_quirk;
> > > +		};
> > > +
> > > +		usb1: usb2@...0000 {
> > > +			compatible = "fsl-usb2-dr-v2.5", "fsl-usb2-dr";
> > > +			reg = <0x0 0x8600000 0x0 0x1000>;
> > > +			interrupts = <0 139 0x4>;
> > > +			dr_mode = "host";
> > > +			phy_type = "ulpi";
> > > +		};
> > 
> > Please keep the nodes sorted in unit-address.
> > 
> > Shawn
> Do you mean to move the node 'usb1: usb2@...0000' forward to where it's address is just before  '@...0000 '?
> I think it's reasonable to put USB controller nodes together in DTS for developer to do issue analysis.

The nodes under simple-bus are maintained in order of unit-address.
Please respect that.

usb2@...0000 should go after sata@...0000 with the current nodes.

Shawn

> > > +
> > >  		sata: sata@...0000 {
> > >  			compatible = "fsl,ls1012a-ahci", "fsl,ls1043a-ahci";
> > >  			reg = <0x0 0x3200000 0x0 0x10000>,
> > > --
> > > 2.1.0.27.g96db324
> > >