linux-kernel - Re: [GIT PULL] sysctl fixes for v4.13-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87r2xkeldu.fsf@xmission.com>
Date:   Thu, 13 Jul 2017 04:28:29 -0500
From:   ebiederm@...ssion.com (Eric W. Biederman)
To:     Sedat Dilek <sedat.dilek@...il.com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel@...r.kernel.org,
        Linux Containers <containers@...ts.linux-foundation.org>,
        linux-fsdevel@...r.kernel.org, Andrei Vagin <avagin@...il.com>
Subject: Re: [GIT PULL] sysctl fixes for v4.13-rc1

Sedat Dilek <sedat.dilek@...il.com> writes:

> On Thu, Jul 13, 2017 at 2:45 AM, Eric W. Biederman
> <ebiederm@...ssion.com> wrote:
>>
>> Linus,
>>
>> Please pull the for-linus branch from the git tree:
>>
>>    git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git for-linus
>>
>>    HEAD: 2fd1d2c4ceb2248a727696962cf3370dc9f5a0a4 proc: Fix proc_sys_prune_dcache to hold a sb reference
>>
>> A rather embarassing and hard to hit bug was merged into 4.11-rc1.
>> Andrei Vagin tracked this bug now and after some starting at the
>> code I came up with a fix.
>>
>> Eric
>>
>> From 2fd1d2c4ceb2248a727696962cf3370dc9f5a0a4 Mon Sep 17 00:00:00 2001
>> From: "Eric W. Biederman" <ebiederm@...ssion.com>
>> Date: Thu, 6 Jul 2017 08:41:06 -0500
>> Subject: [PATCH] proc: Fix proc_sys_prune_dcache to hold a sb reference
>>
>> Andrei Vagin writes:
>> FYI: This bug has been reproduced on 4.11.7
> [...]
>
>> Cc: stable@...r.kernel.org
>
> Please add first affected Linux-kernel release.
>
> Cc: stable@...r.kernel.org # 4.11

Please look at the fixes tags below.  Especially when changes are
backported that seems to be a much better indicator of what is
affected than some arbitrary kernel number.

I have included a Fixes tags for the originally buggy commit and
a Fixes tag for the incomplete fix for the originally buggy commit.

As a rule I only include a kernel version number if the originally
affected kernel is not in Linus's git tree, and not in Thomas's
conversion of the original bitkeeper tree to git.

>
> - Sedat -
>
>> Reported-by: Andrei Vagin <avagin@...il.com>
>> Tested-by: Andrei Vagin <avagin@...nvz.org>
>> Fixes: ace0c791e6c3 ("proc/sysctl: Don't grab i_lock under sysctl_lock.")
>> Fixes: d6cffbbe9a7e ("proc/sysctl: prune stale dentries during unregistering")
>> Signed-off-by: "Eric W. Biederman" <ebiederm@...ssion.com>

Eric