linux-kernel - Re: [PATCH] drm: Add missing field copy in compat_drm_version

Open Source and information security mailing list archives

Message-ID: <20170713123655.n56qor3hq7jqt33h@phenom.ffwll.local>
Date:   Thu, 13 Jul 2017 14:36:55 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     Jeffy Chen <jeffy.chen@...k-chips.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Dave Airlie <airlied@...il.com>
Cc:     linux-kernel@...r.kernel.org, briannorris@...omium.org,
        dianders@...omium.org, dri-devel@...ts.freedesktop.org,
        Daniel Vetter <daniel.vetter@...el.com>
Subject: Re: [PATCH] drm: Add missing field copy in compat_drm_version

On Wed, Jul 12, 2017 at 02:18:32PM +0800, Jeffy Chen wrote:
> DRM_IOCTL_VERSION is supposed to update the name_len/date_len/desc_len
> fields to user.
> 
> Fixes: 012c6741c6aa("switch compat_drm_version() to drm_ioctl_kernel()")
> Signed-off-by: Jeffy Chen <jeffy.chen@...k-chips.com>

Reviewed-by: Daniel Vetter <daniel.vetter@...ll.ch>

Linus, since Dave is a bit out with flu and this bug only exists in your
tree (not yet in drm-next), can you pls apply this directly? It's a fumble
in Al's rework. Direct mbox link from patchwork, in case you don't have
that in your archives anywhere:

https://patchwork.freedesktop.org/patch/166318/mbox/

Thanks, Daniel

> 
> ---
> 
>  drivers/gpu/drm/drm_ioc32.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_ioc32.c b/drivers/gpu/drm/drm_ioc32.c
> index 94acf51..2789356 100644
> --- a/drivers/gpu/drm/drm_ioc32.c
> +++ b/drivers/gpu/drm/drm_ioc32.c
> @@ -112,6 +112,9 @@ static int compat_drm_version(struct file *file, unsigned int cmd,
>  	v32.version_major = v.version_major;
>  	v32.version_minor = v.version_minor;
>  	v32.version_patchlevel = v.version_patchlevel;
> +	v32.name_len = v.name_len;
> +	v32.date_len = v.date_len;
> +	v32.desc_len = v.desc_len;
>  	if (copy_to_user((void __user *)arg, &v32, sizeof(v32)))
>  		return -EFAULT;
>  	return 0;
> -- 
> 2.1.4
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives