linux-kernel - Re: [PATCH v2 01/18] mfd: madera: Add register definitions for Cirrus Logic Madera codecs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1499949850.4826.88.camel@rf-debian.wolfsonmicro.main>
Date:   Thu, 13 Jul 2017 13:44:10 +0100
From:   Richard Fitzgerald <rf@...nsource.wolfsonmicro.com>
To:     Mark Brown <broonie@...nel.org>
CC:     Lee Jones <lee.jones@...aro.org>, <linus.walleij@...aro.org>,
        <gnurou@...il.com>, <robh+dt@...nel.org>, <tglx@...utronix.de>,
        <jason@...edaemon.net>, <alsa-devel@...a-project.org>,
        <patches@...nsource.wolfsonmicro.com>,
        <linux-gpio@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 01/18] mfd: madera: Add register definitions for
 Cirrus Logic Madera codecs


On Thu, 2017-07-13 at 11:05 +0100, Mark Brown wrote:
> On Thu, Jul 13, 2017 at 09:02:10AM +0100, Lee Jones wrote:
> 
> > This patch has been rejected by Linus.
> 
> > https://lkml.org/lkml/2017/7/7/579
> 
> Hrm, when I used to push the register definition patches I did elide all
> the obviously repeated register banks like the write sequencer one that
> Linus is calling out there.  I'm surprised by the "every single line"
> bit though...

Linux doesn't say what he wants us to do about it. I could manually
strip out a few more definitions but seriously, it makes the code a lot
harder to maintain if we can't grep it for use of registers and register
fields. They are big chips, they have a lot of stuff in the registers.