linux-kernel - Re: [PATCH net 20/20] net/hinic: Add ethtool and stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a83d8d80-8a4f-1a65-ff4e-71bf4d0828d1@huawei.com>
Date:   Thu, 13 Jul 2017 16:16:46 +0300
From:   "Aviad Krawczyk (A)" <aviad.krawczyk@...wei.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     <davem@...emloft.net>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>, <bc.y@...wei.com>,
        <victor.gissin@...wei.com>, <zhaochen6@...wei.com>,
        <tony.qu@...wei.com>
Subject: Re: [PATCH net 20/20] net/hinic: Add ethtool and stats


Hi Andrew,

We will separate the patches when we will resubmit.

Aviad

On 7/12/2017 6:43 PM, Andrew Lunn wrote:
> On Wed, Jul 12, 2017 at 10:17:26PM +0800, Aviad Krawczyk wrote:
> 
> Hi Avaid
> 
>> +
>> +static void hinic_tx_timeout(struct net_device *netdev)
>> +{
>> +	struct hinic_dev *nic_dev = netdev_priv(netdev);
>> +
>> +	netif_err(nic_dev, drv, netdev, "Tx timeout\n");
>> +}
>> +
>> +#ifdef CONFIG_NET_POLL_CONTROLLER
>> +static void hinic_netpoll(struct net_device *netdev)
>> +{
>> +	struct hinic_dev *nic_dev = netdev_priv(netdev);
>> +	struct hinic_hwdev *hwdev = nic_dev->hwdev;
>> +	int i, num_qps = hinic_hwdev_num_qps(hwdev);
>> +
>> +	for (i = 0; i < num_qps; i++) {
>> +		struct hinic_txq *txq = &nic_dev->txqs[i];
>> +		struct hinic_rxq *rxq = &nic_dev->rxqs[i];
>> +
>> +		napi_schedule(&txq->napi);
>> +		napi_schedule(&rxq->napi);
>> +	}
>> +}
>> +#endif
> 
> This has nothing to do with ethtool support. Separate patch please.
> 
>      Andrew
> 
> .
>