linux-kernel - Re: [PATCH] HID: multitouch: do not blindly set EV_KEY or EV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.20.1707131650340.26362@cbobk.fhfr.pm>
Date:   Thu, 13 Jul 2017 16:51:22 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Matthias Fend <Matthias.Fend@...fvision.net>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: multitouch: do not blindly set EV_KEY or EV_ABS
 bits

On Tue, 11 Jul 2017, Dmitry Torokhov wrote:

> Now that input core insists on having dev->absinfo when device claims to
> generate EV_ABS in its dev->evbit, we should not be blindly setting that
> bit.
> 
> The code in question might have been needed before input_set_abs_params()
> started setting EV_ABS in device's evbit, but not anymore, and is now
> breaking devices such as SMART SPNL-6075 Touchscreen.
> 
> Fixes: 6ecfe51b4082 ("Input: refuse to register absolute devices ...")
> Reported-by: Matthias Fend <Matthias.Fend@...fvision.net>
> Tested-by: Matthias Fend <Matthias.Fend@...fvision.net>
> Cc: stable@...r.kernel.org
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> ---
> 
> Jiri, Benjamin, I marked it for stable as it causes regressions in 4.12
> reported by users. Please take a look.

Thanks for a quick fix, Dmitry. Queued in for-4.13/upstream-fixes branch.

-- 
Jiri Kosina
SUSE Labs