linux-kernel - Re: [PATCH 3/4] perf annotate: Support --show-nr-samples option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <85aed582-df2f-af7d-0704-7291e7e2d0a9@gmail.com>
Date:   Fri, 14 Jul 2017 02:10:40 +0900
From:   Taeung Song <treeze.taeung@...il.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Namhyung Kim <namhyung@...nel.org>,
        Milian Wolff <milian.wolff@...b.com>,
        Jiri Olsa <jolsa@...hat.com>
Subject: Re: [PATCH 3/4] perf annotate: Support --show-nr-samples option



On 07/13/2017 05:13 AM, Arnaldo Carvalho de Melo wrote:
> Em Wed, Jul 12, 2017 at 07:14:14AM +0900, Taeung Song escreveu:
>> Add --show-nr-samples option to perf-annotate
>> so that it corresponds with perf-report.
>> Additionally h->sum is properly renamed h->nr_samples.
> 
> Please first do a patch renaming ->sum to ->nr_samples, then a patch
> supportign --show-nr-samples.
> 
> We can have this new --show-nr-samples option, but perhaps the best way
> would be to have a hotkey (I guess we have for period, right) for this?
> 

You mean we need to add a hotkey for --show-nr-samples on the anntoate 
TUI browser,
right ? I added a 'e' hotkey in other patch, not this patch
Change it ?

> At some point would be good to have some 'S' or other hotkey to save the > current set of output modifiers (nr-samples column, period column, etc)
> in the .perfconfig file.

I don't understand what you said..
Is related a hotkey with things in .perfconfig file ?
I thought hotkeys exist on only annotate TUI browser..
You mean the short option for --show-nr-samples ?

Thanks,
Taeung

> 
> - Arnaldo


SNIP