linux-kernel - Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87eftjl6xg.fsf@nikula.org>
Date:   Fri, 14 Jul 2017 12:11:07 +0300
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     Stéphane Marchesin 
        <stephane.marchesin@...il.com>,
        Ville Syrjälä <ville.syrjala@...ux.intel.com>
Cc:     Grant Grundler <grundler@...omium.org>,
        intel-gfx <intel-gfx@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "dri-devel\@lists.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        Michael Davidson <md@...gle.com>,
        Matthias Kaehlcke <mka@...omium.org>,
        Daniel Vetter <daniel.vetter@...el.com>,
        Stéphane Marchesin <marcheu@...omium.org>
Subject: Re: [Intel-gfx] [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches

On Thu, 13 Jul 2017, Stéphane Marchesin <stephane.marchesin@...il.com> wrote:
> So, if you think this is wrong, can you fix this warning in a way that
> you'd like?

As I replied previously [1], with more background, fixing the warnings
properly, in a way that actually improves the code instead of making it
worse, would mean a bunch of churn that's not just purely mechanical
conversion.

Unless you can point out a bug which is actually caused by mixing the
types (which is mostly intentional, see the background) I have a hard
time telling people this should be a priority. Definitely something we'd
like to do in the long run and pedantically correct (and I tend to
prefer code that way) but we certainly have more important things to do.

BR,
Jani.

[1] http://mid.mail-archive.com/87wp9rahjy.fsf@intel.com

-- 
Jani Nikula, Intel Open Source Technology Center