linux-kernel - Re: [PATCH][net-next] svcrdma: fix an incorrect check on -E2BIG and -EINVAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170714013914.GA14085@fieldses.org>
Date:   Thu, 13 Jul 2017 21:39:14 -0400
From:   "J. Bruce Fields" <bfields@...ldses.org>
To:     Chuck Lever <chuck.lever@...cle.com>
Cc:     Colin King <colin.king@...onical.com>,
        Trond Myklebust <trond.myklebust@...marydata.com>,
        Anna Schumaker <anna.schumaker@...app.com>,
        Jeff Layton <jlayton@...chiereds.net>,
        "David S . Miller" <davem@...emloft.net>,
        Sagi Grimberg <sagi@...mberg.me>,
        Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][net-next] svcrdma: fix an incorrect check on -E2BIG and
 -EINVAL

On Thu, Jul 13, 2017 at 01:53:10PM -0400, Chuck Lever wrote:
> 
> > On Jul 13, 2017, at 1:51 PM, Colin King <colin.king@...onical.com> wrote:
> > 
> > From: Colin Ian King <colin.king@...onical.com>
> > 
> > The current check will always be true and will always jump to
> > err1, this looks dubious to me. I believe && should be used
> > instead of ||.
> > 
> > Detected by CoverityScan, CID#1450120 ("Logically Dead Code")
> > 
> > Fixes: 107c1d0a991a ("svcrdma: Avoid Send Queue overflow")
> > Signed-off-by: Colin Ian King <colin.king@...onical.com>
> 
> Reviewed-by: Chuck Lever <chuck.lever@...cle.com>
> 
> Dan reported this today, and I have a similar patch in my
> "pending for-rc" series. This one works too.

Applied and merged upstream, thanks.

--b.