linux-kernel - Re: [PATCH v2 2/2] nvmet: preserve controller serial number between reboots

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170714123208.GE26187@lst.de>
Date:   Fri, 14 Jul 2017 14:32:08 +0200
From:   Christoph Hellwig <hch@....de>
To:     Johannes Thumshirn <jthumshirn@...e.de>
Cc:     Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>,
        Keith Busch <keith.busch@...el.com>,
        Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
        Linux NVMe Mailinglist <linux-nvme@...ts.infradead.org>
Subject: Re: [PATCH v2 2/2] nvmet: preserve controller serial number
        between reboots

This patch itself looks good:

Reviewed-by: Christoph Hellwig <hch@....de>

>  static struct configfs_attribute *nvmet_subsys_attrs[] = {
>  	&nvmet_subsys_attr_attr_allow_any_host,
>  	&nvmet_subsys_attr_version,
> +	&nvmet_subsys_attr_attr_serial,

but the new version attribute really needs the attr prefix so that
nvmetcli can pick it up.  And we should also add nvmetcli support
for it.  Can you do the rename before your series to ease backporting
as that should go into 3.12 (just like your serial number fix).