linux-kernel - Re: [PATCH 1/4] kasan: support alloca() poisoning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0e51dc15-1c93-2326-444d-8257b61af54f@virtuozzo.com>
Date:   Fri, 14 Jul 2017 19:52:05 +0300
From:   Andrey Ryabinin <aryabinin@...tuozzo.com>
To:     Greg Hackmann <ghackmann@...gle.com>,
        Alexander Potapenko <glider@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Michal Marek <mmarek@...e.com>
Cc:     linux-kernel@...r.kernel.org, kasan-dev@...glegroups.com,
        linux-mm@...ck.org, linux-kbuild@...r.kernel.org,
        Matthias Kaehlcke <mka@...omium.org>,
        Michael Davidson <md@...gle.com>
Subject: Re: [PATCH 1/4] kasan: support alloca() poisoning

On 07/14/2017 01:49 AM, Greg Hackmann wrote:
> On 07/10/2017 03:30 AM, Andrey Ryabinin wrote:
>> gcc now supports this too. So I think this patch should enable it.
>> It's off by default so you'll have to add --param asan-instrument-allocas=1 into cflags
>> to make it work
> 
> Thanks, will fix.  For now, it looks like I'll need to build gcc from git to test this?
> 

Right, you'll need quite fresh revision >= 250032

>>>   lib/test_kasan.c  | 22 ++++++++++++++++++++++
>>
>> Tests would be better as a separate patch.
> 
> I was following the precedent in 828347f8f9a5 ("kasan: support use-after-scope detection") which added both at the same time. But I can split the test off into a separate patch if you feel really strongly about it.

Please, do the split.