linux-kernel - Re: [PATCH] perf/x86/intel: Fix debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87d193lyqe.fsf@firstfloor.org>
Date:   Fri, 14 Jul 2017 10:22:49 -0700
From:   Andi Kleen <andi@...stfloor.org>
To:     Jiri Olsa <jolsa@...nel.org>
Cc:     Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Kan Liang <kan.liang@...el.com>
Subject: Re: [PATCH] perf/x86/intel: Fix debug_store reset field for freq events

Jiri Olsa <jolsa@...nel.org> writes:
>
> Setting the reset field to 0 for freq events.

Looks good to me.

Reviewed-by: Andi Kleen <ak@...ux.intel.com>

BTW I suspect there's a related bug that

perf record -e '{cycles:pp,branches}:S' ..

would enable multi record PEBS, even though it shouldn't because
we need the PMI to read the other events.

-Andi