linux-kernel - [PATCH 4/5] drm: via: constify pci_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 15 Jul 2017 12:51:53 +0530
From:   Arvind Yadav <arvind.yadav.cs@...il.com>
To:     airlied@...ux.ie, linux-kernel@...r.kernel.org, bskeggs@...hat.com
Cc:     dri-devel@...ts.freedesktop.org
Subject: [PATCH 4/5] drm: via: constify pci_device_id.

pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
    493	   1072	      0	   1565	    61d	drivers/gpu/drm/via/via_drv.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
    821	    744	      0	   1565	    61d	drivers/gpu/drm/via/via_drv.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
---
 drivers/gpu/drm/via/via_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/via/via_drv.c b/drivers/gpu/drm/via/via_drv.c
index 9e0e539..f58a473 100644
--- a/drivers/gpu/drm/via/via_drv.c
+++ b/drivers/gpu/drm/via/via_drv.c
@@ -53,7 +53,7 @@ static void via_driver_postclose(struct drm_device *dev, struct drm_file *file)
 	kfree(file_priv);
 }

-static struct pci_device_id pciidlist[] = {
+static const struct pci_device_id pciidlist[] = {
 	viadrv_PCI_IDS
 };

-- 
2.7.4