linux-kernel - Re: [PATCH, RESEND 02/14] ata: avoid gcc-7 warning in ata_timing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170715105601.GC2969123@devbig577.frc2.facebook.com>
Date:   Sat, 15 Jul 2017 06:56:01 -0400
From:   Tejun Heo <tj@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Guenter Roeck <linux@...ck-us.net>, linux-ide@...r.kernel.org,
        linux-media@...r.kernel.org, akpm@...ux-foundation.org,
        dri-devel@...ts.freedesktop.org,
        Adam Manzanares <adam.manzanares@....com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Hannes Reinecke <hare@...e.de>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Damien Le Moal <damien.lemoal@....com>
Subject: Re: [PATCH, RESEND 02/14] ata: avoid gcc-7 warning in
 ata_timing_quantize

On Fri, Jul 14, 2017 at 11:25:14AM +0200, Arnd Bergmann wrote:
> gcc-7 warns about the result of a constant multiplication used as
> a boolean:
> 
> drivers/ata/libata-core.c: In function 'ata_timing_quantize':
> drivers/ata/libata-core.c:3164:30: warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
> 
> This slightly rearranges the macro to simplify the code and avoid
> the warning at the same time.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

If the whole series will be routed together,

 Acked-by: Tejun Heo <tj@...nel.org>

If not, please let me know.  I'll push it through
libata/for-4.13-fixes.

Thanks!

-- 
tejun