linux-kernel - Re: [PATCH 1/5] drm: radeon: constify pci_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <94559aac-60b7-d2f9-7594-89e939980dd5@vodafone.de>
Date:   Sat, 15 Jul 2017 15:47:38 +0200
From:   Christian König <deathsimple@...afone.de>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>, airlied@...ux.ie,
        amd-gfx@...ts.freedesktop.org, alexander.deucher@....com,
        dri-devel@...ts.freedesktop.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] drm: radeon: constify pci_device_id.

Am 15.07.2017 um 09:12 schrieb Arvind Yadav:
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
>
> File size before:
>     text	   data	    bss	    dec	    hex	filename
>     6560	  23212	     72	  29844	   7494	gpu/drm/radeon/radeon_drv.o
>
> File size After adding 'const':
>     text	   data	    bss	    dec	    hex	filename
>    28960	    812	     72	  29844	   7494	gpu/drm/radeon/radeon_drv.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Impressive result for such a simple change.

Patch is Reviewed-by: Christian König <christian.koenig@....com>

Are the PCI IDs already const in amdgpu or do we need a similar patch 
there as well? I only see patch 1 of 5 in my inbox.

Christian.

> ---
>   drivers/gpu/drm/radeon/radeon_drv.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
> index e25cb51..b079937 100644
> --- a/drivers/gpu/drm/radeon/radeon_drv.c
> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
> @@ -298,7 +298,7 @@ module_param_named(uvd, radeon_uvd, int, 0444);
>   MODULE_PARM_DESC(vce, "vce enable/disable vce support (1 = enable, 0 = disable)");
>   module_param_named(vce, radeon_vce, int, 0444);
>   
> -static struct pci_device_id pciidlist[] = {
> +static const struct pci_device_id pciidlist[] = {
>   	radeon_PCI_IDS
>   };
>