linux-kernel - Re: [PATCH v2 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170715183745.GA28217@lunn.ch>
Date:   Sat, 15 Jul 2017 20:37:45 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Moritz Fischer <mdf@...nel.org>
Cc:     netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, davem@...emloft.net,
        mark.rutland@....com, robh+dt@...nel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: net: Add bindings for National
 Instruments XGE netdev

On Fri, Jul 14, 2017 at 01:48:45PM -0700, Moritz Fischer wrote:
> This adds bindings for the NI XGE 1G/10G network device.
> 
> Signed-off-by: Moritz Fischer <mdf@...nel.org>
> ---
>  Documentation/devicetree/bindings/net/nixge.txt | 32 +++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/nixge.txt
> 
> diff --git a/Documentation/devicetree/bindings/net/nixge.txt b/Documentation/devicetree/bindings/net/nixge.txt
> new file mode 100644
> index 0000000..9fff5a7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/nixge.txt
> @@ -0,0 +1,32 @@
> +* NI XGE Ethernet controller
> +
> +Required properties:
> +- compatible: Should be "ni,xge-enet-2.00"
> +- reg: Address and length of the register set for the device
> +- interrupts: Should contain tx and rx interrupt
> +- interrupt-names: Should be "rx-irq" and "tx-irq"
> +- phy-mode: See ethernet.txt file in the same directory.

Hi Moritz

phy-handle is now required.

> +Examples (10G generic PHY):
> +	nixge0: ethernet@...00000 {
> +		compatible = "ni,xge-enet-2.00";
> +		reg = <0x40000000 0x6000>;
> +
> +		nvmem-cells = <&eth1_addr>;
> +		nvmem-cell-names = "address";
> +
> +		interrupts = <0 29 4>, <0 30 4>;

IRQ_TYPE_LEVEL_HIGH

> +		interrupt-names = "rx-irq", "tx-irq";
> +		interrupt-parent = <&intc>;
> +
> +		phy-mode = "xgmii";
> +		phy-handle = <&ethernet_phy1>;
> +
> +		ethernet_phy1: ethernet-phy@4 {
> +			compatible = "ethernet-phy-ieee802.3-c45";
> +			reg = <4>;
> +			devices = <0xa>;
> +		};

Since you don't fully implement c45, does this example actually work?
And devices is not a standard phy property.

    Andrew