linux-kernel - Re: [PATCH 10/11] irqchip: digicolor: Drop unnecessary static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170716044926.ysys7aa3k7pfhtc4@tarshish>
Date:   Sun, 16 Jul 2017 07:49:26 +0300
From:   Baruch Siach <baruch@...s.co.il>
To:     Julia Lawall <Julia.Lawall@...6.fr>
Cc:     Thomas Gleixner <tglx@...utronix.de>, keescook@...omium.org,
        kernel-janitors@...r.kernel.org,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <marc.zyngier@....com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 10/11] irqchip: digicolor: Drop unnecessary static

Hi Julia,

On Sat, Jul 15, 2017 at 10:07:45PM +0200, Julia Lawall wrote:
> Drop static on a local variable, when the variable is initialized before
> any possible use.  Thus, the static has no benefit.
> 
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @bad exists@
> position p;
> identifier x;
> type T;
> @@
> static T x@p;
> ...
> x = <+...x...+>
> 
> @@
> identifier x;
> expression e;
> type T;
> position p != bad.p;
> @@
> -static
>  T x@p;
>  ... when != x
>      when strict
> ?x = e;
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

Acked-by: Baruch Siach <baruch@...s.co.il>

Thanks,
baruch

> ---
> These patches are all independent of each other.
> 
>  drivers/irqchip/irq-digicolor.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -u -p a/drivers/irqchip/irq-digicolor.c b/drivers/irqchip/irq-digicolor.c
> --- a/drivers/irqchip/irq-digicolor.c
> +++ b/drivers/irqchip/irq-digicolor.c
> @@ -71,7 +71,7 @@ static void __init digicolor_set_gc(void
>  static int __init digicolor_of_init(struct device_node *node,
>  				struct device_node *parent)
>  {
> -	static void __iomem *reg_base;
> +	void __iomem *reg_base;
>  	unsigned int clr = IRQ_NOREQUEST | IRQ_NOPROBE | IRQ_NOAUTOEN;
>  	struct regmap *ucregs;
>  	int ret;
> 

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@...s.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -