linux-kernel - Re: [PATCH v2 0/3] Qualcomm Light Pulse Generator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170706031813.GC12954@xo-6d-61-c0.localdomain>
Date:   Thu, 6 Jul 2017 05:18:13 +0200
From:   Pavel Machek <pavel@....cz>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Richard Purdie <rpurdie@...ys.net>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        devicetree@...r.kernel.org, Fenglin Wu <fenglinw@...eaurora.org>
Subject: Re: [PATCH v2 0/3] Qualcomm Light Pulse Generator

Hi!

> > >   DT: leds: Add Qualcomm Light Pulse Generator binding
> > 
> > This one should be first.
> > 
> 
> Okay, no problems.
> 
> > And I guess I'd prefer the driver to go in first, before the generic
> > pattern interface.
> > 
> 
> The driver won't compile without the additions to the header file. Would
> you like the rest of the driver to go in first, then the generic
> interface and finally the pattern part of the driver?
> 
> Large portions of the driver doesn't make sense without the pattern
> part, so I think I would prefer it to go in as one patch.

Can we get minimum driver without the pattern parts?

Sorry about the additional work.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html