linux-kernel - Re: [PATCH] Add support of all Foxconn (105b) Broadcom devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 16 Jul 2017 10:53:47 +0300
From:   Dmitry Tunin <hanipouspilot@...il.com>
To:     Marcel Holtmann <marcel@...tmann.org>
Cc:     "Gustavo F. Padovan" <gustavo@...ovan.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        linux-bluetooth <linux-bluetooth@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH] Add support of all Foxconn (105b) Broadcom devices

Hi Marcel,

This one https://github.com/0day-ci/linux/commits/Dmitry-Tunin/Add-support-of-all-Foxconn-105b-Broadcom-devices/20170708-021656
is really garbled. But I wrote to you in a couple of minutes after I
sent it. And then sent the v2.
It looks like you applied a wrong one.

Regards,

Dmitry

2017-07-16 10:15 GMT+03:00 Marcel Holtmann <marcel@...tmann.org>:
> Hi Dmitry,
>
>> There is another device
>>
>> T:  Bus=01 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#=  3 Spd=12  MxCh= 0
>> D:  Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
>> P:  Vendor=105b ProdID=e066 Rev=01.12
>> S:  Manufacturer=Broadcom Corp
>> S:  Product=BCM20702A0
>> S:  SerialNumber=342387DAE35E
>> C:  #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
>> I:  If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
>> I:  If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none)
>> I:  If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
>> I:  If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none)
>>
>> Since we have Cls=ff, we can add all of them.
>>
>> Signed-off-by: Dmitry Tunin <hanipouspilot@...il.com>
>> Cc: stable@...r.kernel.org
>> ---
>> drivers/bluetooth/btusb.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
>> index fa24d69..bf95c13 100644
>> --- a/drivers/bluetooth/btusb.c
>> +++ b/drivers/bluetooth/btusb.c
>> @@ -131,7 +131,7 @@ static const struct usb_device_id btusb_table[] = {
>>       { USB_DEVICE(0x19ff, 0x0239), .driver_info = BTUSB_BCM_PATCHRAM },
>>
>>       /* Broadcom BCM43142A0 (Foxconn/Lenovo) */
>> -     { USB_DEVICE(0x105b, 0xe065), .driver_info = BTUSB_BCM_PATCHRAM },
>> +     { USB_VENDOR_AND_INTERFACE_INFO(0x105b, 0xff, 0x01, 0x01),
>>
>>       /* Broadcom BCM920703 (HTC Vive) */
>>       { USB_VENDOR_AND_INTERFACE_INFO(0x0bb4, 0xff, 0x01, 0x01),
>
> this patch is garbled up. And please include full /sys/kernel/debug/usb/devices for these ones.
>
> Regards
>
> Marcel
>