linux-kernel - Re: [PATCH v4 RESEND 1/2] Documentation: tpm: add powered-while-suspended binding documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1500204238.8397.3.camel@linux.intel.com>
Date:   Sun, 16 Jul 2017 14:23:58 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Sonny Rao <sonnyrao@...omium.org>
Cc:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Rob Herring <robh+dt@...nel.org>,
        Peter Huewe <peterhuewe@....de>,
        tpmdd-devel@...ts.sourceforge.net,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Mark Rutland <mark.rutland@....com>,
        Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
        Guenter Roeck <groeck@...omium.org>
Subject: Re: [PATCH v4 RESEND 1/2] Documentation: tpm: add
 powered-while-suspended binding documentation

On Wed, 2017-07-05 at 10:19 -0700, Sonny Rao wrote:
> On Mon, Jul 3, 2017 at 5:57 AM, Jarkko Sakkinen
> <jarkko.sakkinen@...ux.intel.com> wrote:
> > On Tue, Jun 27, 2017 at 12:27:23PM +0200, Enric Balletbo i Serra
> > wrote:
> > > Add a new powered-while-suspended property to control the
> > > behavior of the
> > > TPM suspend/resume.
> > > 
> > > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.c
> > > om>
> > > Signed-off-by: Sonny Rao <sonnyrao@...omium.org>
> > > Reviewed-by: Jason Gunthorpe <jgunthorpe@...idianresearch.com>
> > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> > > Acked-by: Rob Herring <robh@...nel.org>
> > > ---
> > > Changes since v3.
> > >   - Rebased on top of linux-next
> > >  Rob Herring
> > >   - Split DT binding from code patch as is preferred.
> > > 
> > > Did not exist on previous versions.
> > > 
> > >  Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt | 6
> > > ++++++
> > >  1 file changed, 6 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/security/tpm/tpm-
> > > i2c.txt b/Documentation/devicetree/bindings/security/tpm/tpm-
> > > i2c.txt
> > > index 8cb638b..85c8216 100644
> > > --- a/Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt
> > > +++ b/Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt
> > > @@ -8,6 +8,12 @@ Required properties:
> > >                     the firmware event log
> > >  - linux,sml-size : size of the memory allocated for the firmware
> > > event log
> > > 
> > > +Optional properties:
> > > +
> > > +- powered-while-suspended: present when the TPM is left powered
> > > on between
> > > +                           suspend and resume (makes the
> > > suspend/resume
> > > +                           callbacks do nothing).
> > > +
> > >  Example (for OpenPower Systems with Nuvoton TPM 2.0 on I2C)
> > >  ----------------------------------------------------------
> > > 
> > > --
> > > 2.9.3
> > > 
> > 
> > So... should I apply this?
> 
> Hi, since you applied the code part, it would make sense to apply the
> documentation too.
> 
> > 
> > /Jarkko

Applied. Sorry for the delay.

/Jarkko