linux-kernel - Re: [PATCH 2/4] ubifs: Fix unlink code wrt. double hash lookups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc60f428-9589-e1d1-d903-e8af0d96bf9c@nod.at>
Date:   Sun, 16 Jul 2017 14:17:00 +0200
From:   Richard Weinberger <richard@....at>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Hyunchul Lee <hyc.lee@...il.com>, kernel-team@....com,
        Artem Bityutskiy <dedekind1@...il.com>,
        MTD Maling List <linux-mtd@...ts.infradead.org>,
        david.oberhollenzer@...ma-star.at,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/4] ubifs: Fix unlink code wrt. double hash lookups

Geert,

Am 16.07.2017 um 14:12 schrieb Geert Uytterhoeven:
> Hi Richard,
> 
> On Sun, Mar 19, 2017 at 9:46 PM, Richard Weinberger <richard@....at> wrote:
>> Am 09.03.2017 um 08:04 schrieb Hyunchul Lee:
>>>> -    int n, err, type = key_type(c, key);
>>>> -    struct ubifs_znode *znode;
>>>> +    int err;
> 
>     fs/ubifs/tnc.c: In function ‘search_dh_cookie’:
>     fs/ubifs/tnc.c:1893: warning: ‘err’ is used uninitialized in this function
> 
> None of Hyunchul's review comments below ended up in commit 781f675e2d7ec120
> ("ubifs: Fix unlink code wrt. double hash lookups")?

Oh, that was not indented.
Maybe I've selected the wrong patch from patchwork.
Will sort out.

Thanks for pointing out,
//richard