lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 16 Jul 2017 14:56:46 +0100 From: Ben Hutchings <ben@...adent.org.uk> To: linux-kernel@...r.kernel.org, stable@...r.kernel.org CC: akpm@...ux-foundation.org, "Johan Hovold" <johan@...nel.org>, "David Vrabel" <david.vrabel@....com>, "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>, "Inaky Perez-Gonzalez" <inaky.perez-gonzalez@...el.com> Subject: [PATCH 3.16 042/178] uwb: hwa-rc: fix NULL-deref at probe 3.16.46-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold <johan@...nel.org> commit daf229b15907fbfdb6ee183aac8ca428cb57e361 upstream. Make sure to check the number of endpoints to avoid dereferencing a NULL-pointer should a malicious device lack endpoints. Note that the dereference happens in the start callback which is called during probe. Fixes: de520b8bd552 ("uwb: add HWA radio controller driver") Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@...el.com> Cc: David Vrabel <david.vrabel@....com> Signed-off-by: Johan Hovold <johan@...nel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Signed-off-by: Ben Hutchings <ben@...adent.org.uk> --- drivers/uwb/hwa-rc.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/uwb/hwa-rc.c +++ b/drivers/uwb/hwa-rc.c @@ -825,6 +825,9 @@ static int hwarc_probe(struct usb_interf struct hwarc *hwarc; struct device *dev = &iface->dev; + if (iface->cur_altsetting->desc.bNumEndpoints < 1) + return -ENODEV; + result = -ENOMEM; uwb_rc = uwb_rc_alloc(); if (uwb_rc == NULL) {
Powered by blists - more mailing lists