linux-kernel - Re: [linux-next][bisected 1c0eaf0f] Today's next kernel fails to boot on ppc bare-metal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 Jul 2017 11:37:06 +0530
From:   Abdul Haleem <abdhalee@...ux.vnet.ibm.com>
To:     Michael Ellerman <mpe@...erman.id.au>
Cc:     linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-next <linux-next@...r.kernel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        sachinp <sachinp@...ux.vnet.ibm.com>, benh@...nel.crashing.org,
        mikey@...ling.org
Subject: Re: [linux-next][bisected 1c0eaf0f] Today's next kernel fails to
 boot on ppc bare-metal

On Mon, 2017-07-17 at 12:10 +1000, Michael Ellerman wrote:
> Hi Abdul,
> 
> Thanks for the bug report.
> 
> Abdul Haleem <abdhalee@...ux.vnet.ibm.com> writes:
> > Hi 
> >
> > Today's linux-next fails to boot on ppc bare-metal
> >
> > Test: Boot
> > Machine: Power 8 bare-metal
> > kernel: 4.12.0-next-20170713
> > gcc: version 4.8.5
> > config : Tul-NV-config attached.
> 
> [swearing redacted]
> 
> Does this help?

Yes, it fixes the boot issue. Thanks for the fix.

With below patch, I was able to successfully boot
4.13.0-rc1-next-20170717 kernel on ppc bare-metal

Reported-and-tested-by: Abdul Haleem <abdhalee@...ux.vnet.ibm.com>

> 
> diff --git a/arch/powerpc/platforms/powernv/opal.c b/arch/powerpc/platforms/powernv/opal.c
> index 9b87abb178f0..cad6b57ce494 100644
> --- a/arch/powerpc/platforms/powernv/opal.c
> +++ b/arch/powerpc/platforms/powernv/opal.c
> @@ -78,7 +78,7 @@ void opal_configure_cores(void)
>  	 *  ie. Host hash  supports  hash guests
>  	 *      Host radix supports  hash/radix guests
>  	 */
> -	if (cpu_has_feature(CPU_FTR_ARCH_300)) {
> +	if (early_cpu_has_feature(CPU_FTR_ARCH_300)) {
>  		reinit_flags |= OPAL_REINIT_CPUS_MMU_HASH;
>  		if (early_radix_enabled())
>  			reinit_flags |= OPAL_REINIT_CPUS_MMU_RADIX;
> 


-- 
Regard's

Abdul Haleem
IBM Linux Technology Centre