linux-kernel - Re: [PATCH v2] kbuild: trivial cleanups on the comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 Jul 2017 20:13:15 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Cao jin <caoj.fnst@...fujitsu.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Michal Marek <mmarek@...e.com>
Subject: Re: [PATCH v2] kbuild: trivial cleanups on the comments

Hi Cao,


2017-07-16 19:12 GMT+09:00 Cao jin <caoj.fnst@...fujitsu.com>:
> index 61f87a9..f0a4ada 100644
> --- a/scripts/Kbuild.include
> +++ b/scripts/Kbuild.include
> @@ -85,8 +85,8 @@ TMPOUT := $(if $(KBUILD_EXTMOD),$(firstword $(KBUILD_EXTMOD))/)
>
>  # try-run
>  # Usage: option = $(call try-run, $(CC)...-o "$$TMP",option-ok,otherwise)
> -# Exit code chooses option. "$$TMP" is can be used as temporary file and
> -# is automatically cleaned up.
> +# Exit code chooses option. "$$TMP" serves as temporary file and is
> +# automatically cleaned up.


I am not a native speaker, but I think "file" is countable.

Maybe, is "as a temporary file" even better?




> diff --git a/scripts/basic/Makefile b/scripts/basic/Makefile
> index ec10d93..edd983f 100644
> --- a/scripts/basic/Makefile
> +++ b/scripts/basic/Makefile
> @@ -1,5 +1,5 @@
>  ###
> -# Makefile.basic lists the most basic programs used during the build process.
> +# scripts/basic/Makefile lists the most basic programs used during the build process.

This change is correct, but this line will exceed 80 cols limit.

Wrap the lines, or reword like "This Makefile lists ..."

Either will do.



>  # The programs listed herein are what are needed to do the basic stuff,
>  # such as fix file dependencies.
>  # This initial step is needed to avoid files to be recompiled






-- 
Best Regards
Masahiro Yamada