linux-kernel - Re: [PATCH] staging: unisys: visorbus: constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Jul 2017 17:43:14 +0530
From:   Arvind Yadav <arvind.yadav.cs@...il.com>
To:     Greg KH <greg@...ah.com>
Cc:     david.kershner@...sys.com, Timothy.Sell@...sys.com,
        bryan.thompson@...sys.com, jon.frisch@...sys.com,
        david.binder@...sys.com, sparmaintainer@...sys.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: unisys: visorbus: constify attribute_group
 structures.

Hi Greg,


On Monday 17 July 2017 04:15 PM, Greg KH wrote:
> On Mon, Jul 17, 2017 at 02:55:37PM +0530, Arvind Yadav wrote:
>> attribute_groups are not supposed to change at runtime. All functions
>> working with attribute_groups provided by <linux/sysfs.h> work
>> with const attribute_group. So mark the non-const structs as const.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
>> ---
>>   drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++--
>>   drivers/staging/unisys/visorbus/visorchipset.c  | 2 +-
>>   2 files changed, 3 insertions(+), 3 deletions(-)
> Why not just use the ATTRIBUTE_GROUPS() macro for these?  Or is there
> something that is preventing that?
Yes, we can use. if we are only initializing '.attrs'.
ATTRIBUTE_GROUPS() will not work if we will initialize other member of
attribute_group like 'bin_attrs', 'is_visible', and  'name'.
>
> thanks,
>
> greg k-h
Thanks,
~arvind