linux-kernel - Re: [PATCH] Staging:vc04_services:vchiq_util.c: kzalloc call changed to kcalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170717122635.GB24503@kroah.com>
Date:   Mon, 17 Jul 2017 14:26:35 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     AndyS <lkd1024@...l.ru>
Cc:     eric@...olt.net, stefan.wahren@...e.com, daniels@...labora.com,
        noralf@...nnes.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging:vc04_services:vchiq_util.c: kzalloc call changed
 to kcalloc

On Sun, Jul 16, 2017 at 07:39:08PM +0300, AndyS wrote:
> From: Andrey Severin <lkd1024@...l.ru>
> 
> kzalloc call was changed to kcalloc by checkpatch.pl recommendation
> 
> ---
>  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c
> index 7fa0310e7b9e..2e52f07bbaa9 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c
> @@ -51,7 +51,7 @@ int vchiu_queue_init(VCHIU_QUEUE_T *queue, int size)
>  	sema_init(&queue->pop, 0);
>  	sema_init(&queue->push, 0);
>  
> -	queue->storage = kzalloc(size * sizeof(VCHIQ_HEADER_T *), GFP_KERNEL);
> +	queue->storage = kcalloc(size, sizeof(VCHIQ_HEADER_T *), GFP_KERNEL);
>  	if (!queue->storage) {
>  		vchiu_queue_delete(queue);
>  		return 0;
> -- 
> 2.13.2

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch does not have a Signed-off-by: line.  Please read the
  kernel file, Documentation/SubmittingPatches and resend it after
  adding that line.  Note, the line needs to be in the body of the
  email, before the patch, not at the bottom of the patch or in the
  email signature.

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what is needed in order to
  properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what a proper Subject: line should
  look like.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot