linux-kernel - Re: [PATCH 1/2] ARM: OMAP2+: hsmmc.c: Remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFpwb3T4PhQSyUwWDwpEnOwVDxLeK7hAMS0Q4P3tzPXXrQ@mail.gmail.com>
Date:   Mon, 17 Jul 2017 15:08:54 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Faiz Abbas <faiz_abbas@...com>
Cc:     Tony Lindgren <tony@...mide.com>,
        Russell King <linux@...linux.org.uk>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        linux-omap <linux-omap@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Kishon <kishon@...com>, Ravikumar Kattekola <rk@...com>,
        Sekhar Nori <nsekhar@...com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Peter Ujfalusi <peter.ujfalusi@...com>
Subject: Re: [PATCH 1/2] ARM: OMAP2+: hsmmc.c: Remove dead code

On 14 July 2017 at 14:46, Faiz Abbas <faiz_abbas@...com> wrote:
> Most platforms using OMAP hsmmc driver have switched to device tree
> for passing platform data to omap_hsmmc.c driver.
>
> The hsmmc.c file in mach-omap2 exists only to support pandora board
> which uses wl1251 driver in legacy platform data mode.
>
> Hence, remove the dead code not used by the pandora board.
>
> Signed-off-by: Faiz Abbas <faiz_abbas@...com>

I just got an ack from Tony to pick this up. So I did that (including
the mmc change in patch 2) and intend to send this for 4.13 rcs, via
my fixes branch in my mmc tree.

However the below comment for testing puzzles me. Either it's dead
code or not, so then what is there to test? :-)

Anyway, it's available on my fixes and next branch, so let's see if
zero build reports some issues.

> ---
> This is only compile tested. Someone with a pandora board should help
> test this for functionality.
>
>  arch/arm/mach-omap2/hsmmc.c | 239 +-------------------------------------------
>  arch/arm/mach-omap2/hsmmc.h |   9 --
>  2 files changed, 2 insertions(+), 246 deletions(-)

[...]

Kind regards
Uffe