linux-kernel - Re: [PATCH] perf probe: Fix build failure for get_target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170717131108.GC10517@kernel.org>
Date:   Mon, 17 Jul 2017 10:11:08 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>
Cc:     kjlx@...pleofstupid.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf probe: Fix build failure for get_target_map()

Em Mon, Jul 17, 2017 at 04:02:22PM +0530, Ravi Bangoria escreveu:
> Commit 801bc8193463 ("perf probe: Allow placing uprobes in
> alternate namespaces.") is causing a build failure on powerpc:
> 
>   error: incompatible type for argument 2 of 'get_target_map'
>   map = get_target_map(pev->target, pev->uprobes);
>                                     ^~~
> 
> Fix it by changing parameters of get_target_map().

Thanks, since this hasn't made it to Ingo I'll fold this into the patch
where the problem was introduced, adding credits to you, leaving a Link
to this message, so that we don't lose bisection in this area on
powerpc.

- Arnaldo
 
> Fixes: 801bc8193463 ("perf probe: Allow placing uprobes in alternate namespaces.")
> Signed-off-by: Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>
> ---
>  tools/perf/arch/powerpc/util/sym-handling.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/arch/powerpc/util/sym-handling.c b/tools/perf/arch/powerpc/util/sym-handling.c
> index bf9a259..9c4e23d 100644
> --- a/tools/perf/arch/powerpc/util/sym-handling.c
> +++ b/tools/perf/arch/powerpc/util/sym-handling.c
> @@ -126,7 +126,7 @@ void arch__post_process_probe_trace_events(struct perf_probe_event *pev,
>  	struct rb_node *tmp;
>  	int i = 0;
>  
> -	map = get_target_map(pev->target, pev->uprobes);
> +	map = get_target_map(pev->target, pev->nsi, pev->uprobes);
>  	if (!map || map__load(map) < 0)
>  		return;
>  
> -- 
> 2.1.4