linux-kernel - Re: [PATCH 1/1] netfilter: nf_ct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170717151745.GA25741@salvia>
Date:   Mon, 17 Jul 2017 17:17:45 +0200
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Jiri Slaby <jslaby@...e.cz>
Cc:     linux-kernel@...r.kernel.org, Gao Feng <fgao@...ai8.com>,
        Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
        Florian Westphal <fw@...len.de>,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org
Subject: Re: [PATCH 1/1] netfilter: nf_ct_expect: fix expect removal

Hi Jiri,

On Mon, Jul 17, 2017 at 05:06:48PM +0200, Jiri Slaby wrote:
> Commit ec0e3f01114a ("netfilter: nf_ct_expect: Add
> nf_ct_remove_expect()") introduced a helper nf_ct_remove_expect. It was
> used over the code, but one location used a wrong variable and it
> resulted in a crash in this call stack:
>   -> nf_ct_expect_related_report
>   -> nf_ct_remove_expect
>   -> del_timer
>   -> detach_if_pending
> 
> Switch to the proper variable.
> 
> Fixes: ec0e3f01114a
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>

I have pushed out a similar fix from Florian:

https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git/commit/?id=36ac344e16e04e3e55e8fed7446095a6458c64e6

Thanks for the fix anyway.