| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20170717155306.5tfzzvsu6w7pjzdu@phenom.ffwll.local>
Date: Mon, 17 Jul 2017 17:53:06 +0200
From: Daniel Vetter <daniel@...ll.ch>
To: Brian Norris <briannorris@...omium.org>
Cc: Sean Paul <seanpaul@...omium.org>, David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel.vetter@...el.com>,
Jani Nikula <jani.nikula@...ux.intel.com>,
linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/vgem: add compat_ioctl support
On Fri, Jul 14, 2017 at 08:12:12PM -0700, Brian Norris wrote:
> DRM drivers should supply a compat version if they're going to provide
> an ioctl implementation at all. This can confuse 32-bit user space on a
> 64-bit system.
>
> Signed-off-by: Brian Norris <briannorris@...omium.org>
Thanks, applied.
-Daniel
> ---
> drivers/gpu/drm/vgem/vgem_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
> index 9fee38a942c4..3835656e2baf 100644
> --- a/drivers/gpu/drm/vgem/vgem_drv.c
> +++ b/drivers/gpu/drm/vgem/vgem_drv.c
> @@ -220,6 +220,7 @@ static const struct file_operations vgem_driver_fops = {
> .poll = drm_poll,
> .read = drm_read,
> .unlocked_ioctl = drm_ioctl,
> + .compat_ioctl = drm_compat_ioctl,
> .release = drm_release,
> };
>
> --
> 2.13.2.932.g7449e964c-goog
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
Powered by blists - more mailing lists