linux-kernel - Re: [f2fs-dev] [PATCH] f2fs: include seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170717165504.GA81128@jaegeuk-macbookpro.roam.corp.google.com>
Date:   Mon, 17 Jul 2017 09:55:04 -0700
From:   Jaegeuk Kim <jaegeuk@...nel.org>
To:     Chao Yu <chao@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net,
        Eric Biggers <ebiggers@...gle.com>
Subject: Re: [f2fs-dev] [PATCH] f2fs: include seq_file.h for sysfs.c

On 07/17, Chao Yu wrote:
> Hi Jaegeuk,
> 
> On 2017/7/14 9:01, Jaegeuk Kim wrote:
> > This patch includes seq_file.h to avoid compile error.
> 
> I didn't hit the error, I guess that's because we have included f2fs_fs.h
> in sysfs.c, the inclusion relation is like this:
> - sysfs.c
>  - f2fs_fs.h
>   - pagemap.h
>    - fs.h
>     - struct seq_file

What about seq ops such as seq_puts?

Thanks,

> 
> Thanks,
> 
> > 
> > Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> > Signed-off-by: Jaegeuk Kim <jaegeuk@...nel.org>
> > ---
> >  fs/f2fs/sysfs.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
> > index 9adc202fcd6f..71191d89917d 100644
> > --- a/fs/f2fs/sysfs.c
> > +++ b/fs/f2fs/sysfs.c
> > @@ -11,6 +11,7 @@
> >   */
> >  #include <linux/proc_fs.h>
> >  #include <linux/f2fs_fs.h>
> > +#include <linux/seq_file.h>
> >  
> >  #include "f2fs.h"
> >  #include "segment.h"
> >