linux-kernel - Re: [PATCH v2 4/4] Staging: Lustre Fix block statement style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F6F7D587-CD46-40B8-A5B5-678B6A16AD8F@intel.com>
Date:   Mon, 17 Jul 2017 17:44:59 +0000
From:   "Dilger, Andreas" <andreas.dilger@...el.com>
To:     Craig Inches <craig@...iginches.com>
CC:     "Drokin, Oleg" <oleg.drokin@...el.com>,
        James Simmons <jsimmons@...radead.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "lustre-devel@...ts.lustre.org" <lustre-devel@...ts.lustre.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 4/4] Staging: Lustre Fix block statement style issue

On Jul 12, 2017, at 03:03, Craig Inches <craig@...iginches.com> wrote:
> 
> This fixes a block statement which didnt end with */
> 
> Signed-off-by: Craig Inches <Craig@...iginches.com>
> ---
> drivers/staging/lustre/include/linux/lnet/socklnd.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/include/linux/lnet/socklnd.h b/drivers/staging/lustre/include/linux/lnet/socklnd.h
> index dd5bc0e46560..a1ae66ede7a8 100644
> --- a/drivers/staging/lustre/include/linux/lnet/socklnd.h
> +++ b/drivers/staging/lustre/include/linux/lnet/socklnd.h
> @@ -76,7 +76,8 @@ struct ksock_msg {
> 	__u64	ksm_zc_cookies[2];	/* Zero-Copy request/ACK cookie */
> 	union {
> 		struct ksock_lnet_msg lnetmsg; /* lnet message, it's empty if
> -					  * it's NOOP */
> +						* it's NOOP
> +						*/

Rather than making the multi-line comments even more space consuming (I'm not a big
fan of "*/ must be on a line by itself" since it wastes a lot of vertical space),
I'd prefer to just shorten the comment, if possible, like:

		struct ksock_lnet_msg lnetmsg; /* lnet message, empty if NOOP */

Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation