linux-kernel - Re: [Intel-gfx] [PATCH] drm/i915: Return correct EDP voltage swing table for 0.85V

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1500318919.18069.5.camel@dk-H97M-D3H>
Date:   Mon, 17 Jul 2017 18:55:17 +0000
From:   "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@...el.com>
To:     "mka@...omium.org" <mka@...omium.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
        "grundler@...omium.org" <grundler@...omium.org>,
        "Taylor, Clinton A" <clinton.a.taylor@...el.com>,
        "Vetter, Daniel" <daniel.vetter@...el.com>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "stephane.marchesin@...il.com" <stephane.marchesin@...il.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@...el.com>,
        "jani.nikula@...ux.intel.com" <jani.nikula@...ux.intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Return correct EDP voltage swing
 table for 0.85V


Looks like a typo in 

cf54ca8 ("drm/i915/cnl: Implement voltage swing sequence.")

but Cc'ing Rodrigo, Clint to make sure this wasn't a workaround.

-DK


On Mon, 2017-07-17 at 11:21 -0700, Matthias Kaehlcke wrote:
> For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP.
> Use the correct table.
> 
> The error was pointed out by this clang warning:
> 
> drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable
>   'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted
>   [-Wunneeded-internal-declaration]
>     static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = {
> 
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index efb13582dc73..6fa02e6a7a9b 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -1873,7 +1873,7 @@ cnl_get_buf_trans_edp(struct drm_i915_private *dev_priv,
>  	if (dev_priv->vbt.edp.low_vswing) {
>  		if (voltage == VOLTAGE_INFO_0_85V) {
>  			*n_entries = ARRAY_SIZE(cnl_ddi_translations_edp_0_85V);
> -			return cnl_ddi_translations_dp_0_85V;
> +			return cnl_ddi_translations_edp_0_85V;
>  		} else if (voltage == VOLTAGE_INFO_0_95V) {
>  			*n_entries = ARRAY_SIZE(cnl_ddi_translations_edp_0_95V);
>  			return cnl_ddi_translations_edp_0_95V;