linux-kernel - RE: [PATCH 1/2] Tools: hv: vss: Skip freezing filesystems backed by loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BN6PR21MB0689ECB0438D2A215B86BF66D8A00@BN6PR21MB0689.namprd21.prod.outlook.com>
Date:   Mon, 17 Jul 2017 18:59:32 +0000
From:   "Alex Ng (LIS)" <alexng@...rosoft.com>
To:     Greg KH <gregkh@...uxfoundation.org>,
        KY Srinivasan <kys@...rosoft.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        "olaf@...fle.de" <olaf@...fle.de>,
        "apw@...onical.com" <apw@...onical.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "leann.ogasawara@...onical.com" <leann.ogasawara@...onical.com>,
        "marcelo.cerri@...onical.com" <marcelo.cerri@...onical.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Vyronas Tsingaras <vyronas@...ingaras.me>
Subject: RE: [PATCH 1/2] Tools: hv: vss: Skip freezing filesystems backed by
 loop

My apologies. The changelog comment should be more descriptive.

Since a loop device is backed by a file, a backup will already result in
its parent filesystem being frozen. It's sufficient to just freeze the
parent filesystem, so we can skip the loop device.

This avoids a situation where a loop device and its parent filesystem are
both frozen and then thawed out of order. For example, if the loop device
is enumerated first, we would thaw it while its parent filesystem is still
frozen. The thaw operation fails and the loop device remains frozen.

I'll work with KY to send an updated patch with a better comment.

> -----Original Message-----
> From: Greg KH [mailto:gregkh@...uxfoundation.org]
> Sent: Monday, July 17, 2017 6:00 AM
> To: KY Srinivasan <kys@...rosoft.com>
> Cc: linux-kernel@...r.kernel.org; devel@...uxdriverproject.org;
> olaf@...fle.de; apw@...onical.com; vkuznets@...hat.com;
> jasowang@...hat.com; leann.ogasawara@...onical.com;
> marcelo.cerri@...onical.com; Stephen Hemminger
> <sthemmin@...rosoft.com>; Alex Ng (LIS) <alexng@...rosoft.com>;
> Vyronas Tsingaras <vyronas@...ingaras.me>
> Subject: Re: [PATCH 1/2] Tools: hv: vss: Skip freezing filesystems backed by
> loop
> 
> On Sun, Jun 25, 2017 at 12:47:45PM -0700, kys@...hange.microsoft.com
> wrote:
> > From: Alex Ng <alexng@...sages.microsoft.com>
> >
> > Skip loop devices from the freeze/thaw operation.
> 
> Ok, but why?  What is the consequences of this?  Please provide a much
> better changelog comment, especially for something that is supposed to
> be a "fix".
> 
> thanks,
> 
> greg k-h