linux-kernel - Re: [PATCH 1/3] PCI: dwc: Handle host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <000a01d2ff32$d5d59e00$8180da00$@gmail.com>
Date:   Mon, 17 Jul 2017 15:28:13 -0400
From:   "Jingoo Han" <jingoohan1@...il.com>
To:     "'Joao Pinto'" <Joao.Pinto@...opsys.com>,
        "'Bjorn Andersson'" <bjorn.andersson@...aro.org>
Cc:     "'Kishon Vijay Abraham I'" <kishon@...com>,
        "'Bjorn Helgaas'" <bhelgaas@...gle.com>,
        "'Kukjin Kim'" <kgene@...nel.org>,
        "'Krzysztof Kozlowski'" <krzk@...nel.org>,
        "'Richard Zhu'" <hongxing.zhu@....com>,
        "'Lucas Stach'" <l.stach@...gutronix.de>,
        "'Murali Karicheri'" <m-karicheri2@...com>,
        "'Minghuan Lian'" <minghuan.Lian@...escale.com>,
        "'Mingkai Hu'" <mingkai.hu@...escale.com>,
        "'Roy Zang'" <tie-fei.zang@...escale.com>,
        "'Thomas Petazzoni'" <thomas.petazzoni@...e-electrons.com>,
        "'Niklas Cassel'" <niklas.cassel@...s.com>,
        "'Jesper Nilsson'" <jesper.nilsson@...s.com>,
        "'Xiaowei Song'" <songxiaowei@...ilicon.com>,
        "'Binghui Wang'" <wangbinghui@...ilicon.com>,
        "'Stanimir Varbanov'" <svarbanov@...sol.com>,
        "'Pratyush Anand'" <pratyush.anand@...il.com>,
        "'open list:PCI DRIVER FOR TI DRA7XX'" <linux-omap@...r.kernel.org>,
        "'open list:PCI DRIVER FOR TI DRA7XX'" <linux-pci@...r.kernel.org>,
        "'open list'" <linux-kernel@...r.kernel.org>,
        "'moderated list:PCI DRIVER FOR SAMSUNG EXYNOS'" 
        <linux-arm-kernel@...ts.infradead.org>,
        "'moderated list:PCI DRIVER FOR SAMSUNG EXYNOS'" 
        <linux-samsung-soc@...r.kernel.org>,
        "'open list:PCI DRIVER FOR FREESCALE LAYERSCAPE'" 
        <linuxppc-dev@...ts.ozlabs.org>,
        "'open list:PCIE DRIVER FOR AXIS ARTPEC'" <linux-arm-kernel@...s.com>,
        "'open list:PCIE DRIVER FOR QUALCOMM MSM'" 
        <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH 1/3] PCI: dwc: Handle host_init failures

On Monday, July 17, 2017 7:18 AM, Joao Pinto wrote:
> 
> Hi Bjorn Andersson,
> 
> Às 7:39 AM de 7/16/2017, Bjorn Andersson escreveu:
> > In several dwc based drivers host_init can fail, so make sure to
> > propagate and handle this to avoid continuing operation of a driver or
> > hardware in an invalid state.
> >
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> > ---
> >  drivers/pci/dwc/pci-dra7xx.c           |  4 +++-
> >  drivers/pci/dwc/pci-exynos.c           |  4 +++-
> >  drivers/pci/dwc/pci-imx6.c             |  4 +++-
> >  drivers/pci/dwc/pci-keystone.c         |  4 +++-
> >  drivers/pci/dwc/pci-layerscape.c       | 14 ++++++++++----
> >  drivers/pci/dwc/pcie-armada8k.c        |  4 +++-
> >  drivers/pci/dwc/pcie-artpec6.c         |  4 +++-
> >  drivers/pci/dwc/pcie-designware-host.c |  7 +++++--
> >  drivers/pci/dwc/pcie-designware-plat.c |  4 +++-
> >  drivers/pci/dwc/pcie-designware.h      |  2 +-
> >  drivers/pci/dwc/pcie-kirin.c           |  4 +++-
> >  drivers/pci/dwc/pcie-qcom.c            |  6 ++++--
> >  drivers/pci/dwc/pcie-spear13xx.c       |  4 +++-
> >  13 files changed, 47 insertions(+), 18 deletions(-)
> >

[.....]

> 
> A step in the right direction :). In the future we should add host init
> validation in the specific SoC drivers, like Layerscape and Qcom have, to
> assure
> that any problem is treated properly in the core driver.

I agree with your opinion.

> 
> Acked-by: Joao Pinto <jpinto@...opsys.com>

Acked-by: Jingoo Han <jingoohan1@...il.com>

Best regards,
Jingoo Han