linux-kernel - Re: [PATCH 08/11] net: cadence: macb: constify pci_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170717.133809.1388368429079194648.davem@davemloft.net>
Date:   Mon, 17 Jul 2017 13:38:09 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     arvind.yadav.cs@...il.com
Cc:     nicolas.ferre@...rochip.com, kvalo@...eaurora.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/11] net: cadence: macb: constify pci_device_id.

From: Arvind Yadav <arvind.yadav.cs@...il.com>
Date: Mon, 17 Jul 2017 23:41:52 +0530

> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>     791	    336	      0	   1127	    467	net/ethernet/cadence/macb_pci.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>     855	    272	      0	   1127	    467	net/ethernet/cadence/macb_pci.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Applied.