linux-kernel - Re: [PATCH] ALSA: hda: constify pci_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hbmohaajn.wl-tiwai@suse.de>
Date:   Tue, 18 Jul 2017 20:02:04 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Arvind Yadav" <arvind.yadav.cs@...il.com>
Cc:     <alsa-devel@...a-project.org>, <perex@...ex.cz>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: hda: constify pci_device_id.

On Tue, 18 Jul 2017 19:05:06 +0200,
Arvind Yadav wrote:
> 
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    2610	    304	      8	   2922	    b6a	sound/hda/hdac_i915.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>    2674	    240	      8	   2922	    b6a	sound/hda/hdac_i915.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Applied, thanks.


Takashi