linux-kernel - Re: [Intel-gfx] [PATCH v2] drm/i915: Explicit the connector name for DP link training result

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1500405356.20458.12.camel@dk-H97M-D3H>
Date:   Tue, 18 Jul 2017 18:55:52 +0000
From:   "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@...el.com>
To:     "paul.kocialkowski@...ux.intel.com" 
        <paul.kocialkowski@...ux.intel.com>
CC:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Vetter, Daniel" <daniel.vetter@...el.com>,
        "airlied@...ux.ie" <airlied@...ux.ie>
Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: Explicit the connector name
 for DP link training result




On Tue, 2017-07-18 at 17:25 +0300, Paul Kocialkowski wrote:
> This adds the connector name when printing a debug message about the DP
> link training result. It is useful to figure out what connector is
> failing when multiple DP connectors are used.
> 
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@...ux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_dp_link_training.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c
> index b79c1c0e404c..05907fa8a553 100644
> --- a/drivers/gpu/drm/i915/intel_dp_link_training.c
> +++ b/drivers/gpu/drm/i915/intel_dp_link_training.c
> @@ -321,12 +321,16 @@ intel_dp_start_link_train(struct intel_dp *intel_dp)
>  	if (!intel_dp_link_training_channel_equalization(intel_dp))
>  		goto failure_handling;
>  
> -	DRM_DEBUG_KMS("Link Training Passed at Link Rate = %d, Lane count = %d",
> +	DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training Passed at Link Rate = %d, Lane count = %d",
> +		      intel_connector->base.base.id,
> +		      intel_connector->base.name,
>  		      intel_dp->link_rate, intel_dp->lane_count);
>  	return;
>  
>   failure_handling:
> -	DRM_DEBUG_KMS("Link Training failed at link rate = %d, lane count = %d",
> +	DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Link Training failed at link rate = %d, lane count = %d",
> +		      intel_connector->base.base.id,
> +		      intel_connector->base.name,
>  		      intel_dp->link_rate, intel_dp->lane_count);
>  	if (!intel_dp_get_link_train_fallback_values(intel_dp,
>  						     intel_dp->link_rate,


Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@...el.com>

The choice of upper v/s lower case letters in these debug messages is a
bit odd.

Passed/failed
Link rate/link rate
Lane count/lane count