lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 18 Jul 2017 22:03:36 +0200 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: Dmitry Torokhov <dmitry.torokhov@...il.com> Cc: htejun@...il.com, linux-kernel@...r.kernel.org, Guenter Roeck <linux@...ck-us.net> Subject: Re: [PATCH 2/2] sysfs: add devm_sysfs_create_group() and friends On Tue, Jul 18, 2017 at 12:30:58PM -0700, Dmitry Torokhov wrote: > --- a/include/linux/sysfs.h > +++ b/include/linux/sysfs.h > @@ -282,6 +282,16 @@ int __compat_only_sysfs_link_entry_to_kobj(struct kobject *kobj, > struct kobject *target_kobj, > const char *target_name); > > +struct device; Put this in device.h instead? > +int __must_check devm_sysfs_create_group(struct device *dev, > + const struct attribute_group *grp); > +int __must_check devm_sysfs_create_groups(struct device *dev, > + const struct attribute_group **groups); > +void devm_sysfs_remove_group(struct device *dev, > + const struct attribute_group *grp); > +void devm_sysfs_remove_groups(struct device *dev, > + const struct attribute_group **groups); I have finally moved the driver core to only accept/need "groups" not a single "group", so we should only need devm_sysfs_create_groups and devm_sysfs_remove_groups, right? And do we need/want the non-devm versions: device_create_groups() device_remove_groups() ? And you can probably drop the 'sysfs' from the function name if you want. </bikeshedding> :) thanks, greg k-h
Powered by blists - more mailing lists