linux-kernel - Re: [PATCH 1/4] rtc-lib: Add rtc_show_time(const char *prefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5a1a1eab-5d5b-b91c-2990-abbd2d17480e@android.com>
Date:   Tue, 18 Jul 2017 13:08:35 -0700
From:   Mark Salyzyn <salyzyn@...roid.com>
To:     Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:     linux-kernel@...r.kernel.org, rjw@...ysocki.net,
        len.brown@...el.com, pavel@....cz, linux-pm@...r.kernel.org,
        a.zummo@...ertech.it, linux-rtc@...r.kernel.org
Subject: Re: [PATCH 1/4] rtc-lib: Add rtc_show_time(const char *prefix_msg)

On 07/18/2017 01:00 PM, Mark Salyzyn wrote:
> On 07/18/2017 10:52 AM, Alexandre Belloni wrote:
>> Hi,
>>
>> On 18/07/2017 at 10:25:23 -0700, Mark Salyzyn wrote:
>>> . . .
>> Apart from using rtc_time_to_tm (and you should probably use
>> rtc_time64_to_tm), none of this is actually related to the RTC
>> subsystem. I feel like you should find another place to put that, maybe
>> timekeeping_debug.c?
> Makes a lot of sense!
>
> -- Mark

Ooops, timekeeping_debug.c is currently only to support a debugfs node. 
Perhaps a _new_ file in that hierarchy like kernel/time/rtc_show_time.c.

-- Mark