linux-kernel - Re: [PATCH 09/15] mm/hmm/devmem: device memory hotplug using ZONE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <be0503da-f1c4-f3c2-dace-6a9aa02c3186@nvidia.com>
Date:   Tue, 18 Jul 2017 14:41:01 -0700
From:   Evgeny Baskakov <ebaskakov@...dia.com>
To:     Jérôme Glisse <jglisse@...hat.com>,
        <akpm@...ux-foundation.org>, <linux-kernel@...r.kernel.org>,
        <linux-mm@...ck.org>
CC:     John Hubbard <jhubbard@...dia.com>,
        Dan Williams <dan.j.williams@...el.com>,
        David Nellans <dnellans@...dia.com>,
        Mark Hairgrove <mhairgrove@...dia.com>,
        Sherry Cheung <SCheung@...dia.com>,
        Subhash Gutti <sgutti@...dia.com>
Subject: Re: [PATCH 09/15] mm/hmm/devmem: device memory hotplug using
 ZONE_DEVICE v6

On 6/28/17 11:00 AM, Jérôme Glisse wrote:

> +/*
> + * struct hmm_devmem_ops - callback for ZONE_DEVICE memory events
> + *
> + * @free: call when refcount on page reach 1 and thus is no longer use
> + * @fault: call when there is a page fault to unaddressable memory
> + */
> +struct hmm_devmem_ops {
> +	void (*free)(struct hmm_devmem *devmem, struct page *page);
> +	int (*fault)(struct hmm_devmem *devmem,
> +		     struct vm_area_struct *vma,
> +		     unsigned long addr,
> +		     struct page *page,
> +		     unsigned int flags,
> +		     pmd_t *pmdp);
> +};
>

Hi Jerome,

As discussed, could you please add detailed documentation for these 
callbacks?

Specifically, for the 'fault' callback it is important to clarify the 
meaning of each of its parameters and the return value (which error 
codes are expected to be returned from it).

Thanks!

-- 
Evgeny Baskakov
NVIDIA