[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <9392750.bmStGLhEbp@aspire.rjw.lan>
Date: Wed, 19 Jul 2017 00:16:13 +0200
From: "Rafael J. Wysocki" <rjw@...ysocki.net>
To: Juri Lelli <Juri.Lelli@....com>
Cc: Viresh Kumar <viresh.kumar@...aro.org>,
Ingo Molnar <mingo@...hat.com>,
Peter Zijlstra <peterz@...radead.org>,
linux-pm@...r.kernel.org,
Vincent Guittot <vincent.guittot@...aro.org>,
joelaf@...gle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: schedutil: Update last_update from sugov_set_iowait_boost()
On Tuesday, July 18, 2017 12:35:52 PM Juri Lelli wrote:
> On 18/07/17 16:55, Viresh Kumar wrote:
> > On 18-07-17, 12:20, Juri Lelli wrote:
> > > Hi Viresh,
> > >
> > > On 18/07/17 10:24, Viresh Kumar wrote:
>
> [...]
>
> > >
> > > It actually belongs here, IMHO. We update other fields (util, max,
> > > flags)
> >
> > Yeah, because they have bigger roles and aren't specific to iowait
> > boost.
> >
> > > before looking at iowait. Why hiding the time update into a
> > > function dealing with only one of such fields?
> >
> > But last_update is very much specific to iowait_boost only and so it
> > should be updated from sugov_set_iowait_boost() IMHO.
> >
>
> Huh, I see you point. However, I'm using it also to deal with stale CFS
> util values in my patches [1]. Sure, not mainline yet, but I guess I'll
> have to sort of revert your proposed change for my next version. Or
> think of a better idea. :)
Yes, so I'd prefer to prioritize your patches.
The patch from Viresh is purely cosmetic AFAICS and it really can wait.
Thanks,
Rafael
Powered by blists - more mailing lists