linux-kernel - Re: [PATCH v5 00/16] perf tool: add meta-data header support for pipe-mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALcN6mjYLDrEb8fehC=0hS4Pp72RyhJ0USOCs7-8cphRp_pvMQ@mail.gmail.com>
Date:   Mon, 17 Jul 2017 21:39:15 -0700
From:   David Carrillo-Cisneros <davidcc@...gle.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>, Simon Que <sque@...omium.org>,
        Wang Nan <wangnan0@...wei.com>, Jiri Olsa <jolsa@...nel.org>,
        He Kuang <hekuang@...wei.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        David Ahern <dsa@...ulusnetworks.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Stephane Eranian <eranian@...gle.com>,
        Paul Turner <pjt@...gle.com>
Subject: Re: [PATCH v5 00/16] perf tool: add meta-data header support for pipe-mode

On Wed, Jul 12, 2017 at 7:31 AM, Jiri Olsa <jolsa@...hat.com> wrote:
> On Tue, Jul 11, 2017 at 04:52:51PM -0700, David Carrillo-Cisneros wrote:
>> v5: - Fix buffer leaking and size changes in
>>       perf_event__synthesize_features.
>>     - Remove unnecessary renaming.
>>     - Remove extra tabs in do_write_string.
>
> SNIP
>
>>
>> Only patches 14 to 16 have a significant effect in user observed behavior.
>> All other are transparent preparatory changes or bug fixes.
>>
>> David Carrillo-Cisneros (16):
>>   perf header: encapsulate read and swap
>>   perf header: add PROCESS_STR_FUN macro
>>   perf header: fail on write_padded error
>>   perf util: add const modifier to buf in "writen" function
>>   perf header: revamp do_write
>>   perf header: add struct feat_fd for write
>>   perf header: use struct feat_fd for print
>>   perf header: use struct feat_fd to process header records
>>   perf header: don't pass struct perf_file_section to process_##_feat
>>   perf header: use struct feat_fd in read header records
>>   perf header: make write_pmu_mappings pipe-mode friendly
>
> hum, not sure if that's an issue on my side, but I can see
> only patches 0-11 (above portion), missing patches 12-16:

Mmm, no idea. I reposted a new version and also uploaded it to
https://github.com/ccdavid/linux/tree/toup_july16_pipeheaders_02

>
>>   perf header: add a buffer to struct feat_fd
>>   perf header: change FEAT_OP* macros
>>   perf tool: add show_feature_header to perf_tool
>>   perf tools: add feature header record to pipe-mode
>>   perf header: add event desc to pipe-mode header
>
>
> jirka