linux-kernel - Re: [PATCH] staging: iio: adc: add space around substraction operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CEA59923-B6BE-4764-B466-651FE7D5B73F@jic23.retrosnub.co.uk>
Date:   Tue, 18 Jul 2017 06:57:15 +0100
From:   Jonathan Cameron <jic23@...23.retrosnub.co.uk>
To:     Hari Prasath <gehariprasath@...il.com>, lars@...afoo.de
CC:     gehariprasath@...il.com,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: iio: adc: add space around substraction operation



On 18 July 2017 06:38:08 BST, Hari Prasath <gehariprasath@...il.com> wrote:
>Fix checkpatch warning to add space around the substraction operation
>
>Signed-off-by: Hari Prasath <gehariprasath@...il.com>
>---
> drivers/staging/iio/adc/ad7280a.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/staging/iio/adc/ad7280a.c
>b/drivers/staging/iio/adc/ad7280a.c
>index d5ab83f..d79e774 100644
>--- a/drivers/staging/iio/adc/ad7280a.c
>+++ b/drivers/staging/iio/adc/ad7280a.c
>@@ -745,14 +745,14 @@ static irqreturn_t ad7280_event_handler(int irq,
>void *private)
> }
> 
> static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
>-		in_voltage-voltage_thresh_low_value,
>+		in_voltage - voltage_thresh_low_value,
> 		0644,
> 		ad7280_read_channel_config,
> 		ad7280_write_channel_config,
> 		AD7280A_CELL_UNDERVOLTAGE);
> 
> static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
>-		in_voltage-voltage_thresh_high_value,
>+		in_voltage - voltage_thresh_high_value,
> 		0644,
> 		ad7280_read_channel_config,
> 		ad7280_write_channel_config,

Check what this code actually does. 
Using checkpatch gives suggestions of where
to look for issues; it is not always right!

This change breaks the userspace ABI.

Jonathan

Ps when ever  I see a patch involving whitespace and this driver I know I am going to give roughly
this response having done so perhaps 10 times in the past!  

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.