linux-kernel - Re: [PATCH V3 1/5] drivers/fmc: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170718072349.GA15087@kroah.com>
Date:   Tue, 18 Jul 2017 09:23:49 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Alessandro Rubini <rubini@...dd.com>
Cc:     linux-kernel@...r.kernel.org, riehecky@...l.gov,
        federico.vaga@...n.ch
Subject: Re: [PATCH V3 1/5] drivers/fmc: remove unused variable

On Tue, Jul 18, 2017 at 09:00:29AM +0200, Alessandro Rubini wrote:
> > Again, I do not like to take patches without any changelog text at all
> > :(
> 
> Sorry, I added this after the "---" line. I thought it was this one the
> missing item:
> 
>  V3 (Alessandro): fixed From line in patch, added alessandro's acked-by
> 
>  V2 (Pat): added Tested-by and incorrect From line
> 
>  V1 (Pat): picked from ohwr.org repo, where most fmc users pick from.

Ah, sorry, wrong "changelog".  I meant the area that shows up in git
about what this patch does.  There's no description of it other than the
Subject line.  While this is a simple patch, it is always good to say
something like "variable foo was set but never actually used, so it's
safe to remove it as the function it called did not change the hardware
state" or something like that.

thanks,

greg k-h